Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests: Internal currency name and default currency #51

Open
imparium-de opened this issue Jan 17, 2024 · 2 comments
Open

Feature requests: Internal currency name and default currency #51

imparium-de opened this issue Jan 17, 2024 · 2 comments

Comments

@imparium-de
Copy link

imparium-de commented Jan 17, 2024

Heya!
We're currently switching from CMI's currency system to yours and noticed a few QoL things that'd make the integration into other plugins and the general usability a bit easier.

First

Internal Vault currency name
Have an internal currency name that supports legacy color codes.
Why? It seems like a handful of plugins doesn't support MiniMessage yet and therefore, currency names look completely off.


Edit:
If it is not possible to get such an internal value due to vault we would like to ask if it would be possible to add minedown support (minedown supports colour leagecy code) and make it adjustable in the config file whether you want to use this or minimessage.
https://github.com/Phoenix616/MineDown

Example with QuickShop-Hikari (QS dev is aware):
image

Possible config option:

currencies:
- currencyName: vault
  currencySingle: <i><b><green>I</green></b></i>
  currencyPlural: <i><b><green>I</green></b></i>
  currencyNameInternal: §2§lI
  decimalFormat: '#.##'
  languageTag: en-US
  startingBalance: 100.0
  payTax: 0.0

Second

Set default Vault currency when none is specified

When using a command like balance/money <player> <currency> give <amount> [reason...], make <currency> optional by falling back to a specified default currency set in the config (Vault, QuestPoints etc).

@Emibergo02
Copy link
Owner

please use Discord for such things
https://discord.com/invite/EXdPs7BBq9

@imparium-de
Copy link
Author

Alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants