Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make support for default GET arguments in AdhocBrowserPool #349

Open
wzin opened this issue Apr 3, 2017 · 3 comments
Open

Make support for default GET arguments in AdhocBrowserPool #349

wzin opened this issue Apr 3, 2017 · 3 comments
Assignees

Comments

@wzin
Copy link
Contributor

wzin commented Apr 3, 2017

Overview:

This ticket is the other half of the work that's speced out here: https://github.com/EndPointCorp/lg_chef/issues/1273

Requirements:

  • Make it possible to provide list of GET arguments that will be passed to each and every instance of the AdhocBrowser
  • make sure that GET args are unique
  • make it be a param
@wzin wzin added this to the LG 2.5.0 milestone Apr 3, 2017
@minshallj
Copy link
Contributor

arguments should make their way into /var/www/lg/lg-head.xml under /global_get_args/* or something like that. Then adhocBrowserPool should grab all key/values and append <url>?<key1>=<val1>&<key2>=<val2> etc

@minshallj
Copy link
Contributor

test w/ tactile first please to make sure this is even possible.

@wzin wzin removed this from the LG 2.5.0 milestone Apr 13, 2017
@zdenekmaxa zdenekmaxa self-assigned this Apr 20, 2017
@axisofentropy
Copy link
Contributor

Another use case for this: Right now when launching Gigapixel, GET parameters for the portal-launcher Quick Menu don't get passed into the URL. Other applications use an intermediate "launcher" HTML page, but Gigapixel does not (and probably should not) so we need another way to get those passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants