Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make street view window slugs unique #386

Open
mvollrath opened this issue Aug 21, 2018 · 1 comment
Open

Make street view window slugs unique #386

mvollrath opened this issue Aug 21, 2018 · 1 comment
Assignees

Comments

@mvollrath
Copy link
Member

Overview:
The window positioning interface relies on being given a unique window slug for positioning windows. The slug is generated from the configuration of the instance being managed for ease of debugging, but it is not guaranteed to be unique, so identical configurations on the same machine will have overlapping windows with their launchers racing to apply their rules first (or last?)

Requirements:

  • Street View window slugs are unique even when launcher instances have the same fov, yaw and pitch.

Development notes
Here is where the slug is generated.

The Python uuid library seems like an easy way to generate a unique name.

Testing scenario

  • Configure a system with two lg_sv launchers with identical yaw, pitch and fov and launch Street View.
  • Confirm that they have different window names with $ DISPLAY=:0 xwininfo -root -tree
@mvollrath mvollrath reopened this Aug 21, 2018
@FuriousJulius FuriousJulius self-assigned this Dec 7, 2018
@FuriousJulius
Copy link
Member

PR here #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants