Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up lg_sv #394

Open
minshallj opened this issue Dec 11, 2018 · 1 comment
Open

clean up lg_sv #394

minshallj opened this issue Dec 11, 2018 · 1 comment
Assignees

Comments

@minshallj
Copy link
Contributor

Currently we check the panoid to see if we should use "old_streetview" or "streetview" https://github.com/EndPointCorp/lg_ros_nodes/blob/master/lg_sv/src/lg_sv/server.py#L304-L309

We want to be able to have a rosparam toggle this behavior on/off and assign a default streetview type to use. Likely we want to be able to provide a function to the server that can be used to filter a panoid to check if we are using the right type. So in our current set up we'd be passing in a different function for lg_sv and lg_sv_nonfree, one which would just return "streetview_old" when the panoid is < 64 characters (or whatever it does in the code) and another that returns "streetview" when it's >= 64 characters

@FuriousJulius
Copy link
Member

#395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants