Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding to JPEG transfer syntaxes #286

Open
1 of 5 tasks
Enet4 opened this issue Oct 2, 2022 · 2 comments
Open
1 of 5 tasks

Encoding to JPEG transfer syntaxes #286

Enet4 opened this issue Oct 2, 2022 · 2 comments

Comments

@Enet4
Copy link
Owner

Enet4 commented Oct 2, 2022

Decoding JPEG-based transfer syntaxes is already supported, but support for encoding a native DICOM object to JPEG would be good to have.

In a first phase, this amounts to implementing the encode method of the PixelRWAdapter implementation for JPEGAdapter.

@Almeida-a
Copy link
Contributor

I think I can take this issue.

Is there a way to test this new implementation after it is finished?

@Enet4
Copy link
Owner Author

Enet4 commented Oct 25, 2022

Great!

Is there a way to test this new implementation after it is finished?

By lack of a proper transcoding module (efforts are ongoing!), we can test the adapter in isolation by encoding one of the test files, reading the output as a JPEG file using the decoder and checking whether some meta-properties are correct (width, height...). Pixel data check could be done too, but we would need to allow an error margin to account for loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants