From 89a586e9486bbb2604b71d5112b3d9c1abc1959b Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Thu, 2 Nov 2023 13:22:22 -0400 Subject: [PATCH 01/10] fix accessibilty issue with table caption being read out twice --- .../UploadedDocumentsTable.module.scss | 12 +++++++----- .../UploadedDocumentsTable.tsx | 6 ++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.module.scss b/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.module.scss index 40453ab495..dab94ae820 100644 --- a/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.module.scss +++ b/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.module.scss @@ -4,11 +4,6 @@ .uploadedDocumentsTable { width: 100%; - caption { - text-align: left; - margin-bottom: units(2); - margin-top: units(2) - } th { font-size: size('body', '2xs'); @@ -54,6 +49,13 @@ margin-right: 5px !important; } +caption { + text-align: left; + margin-bottom: units(2); + margin-top: units(2); + font-weight: 700; +} + .missingInfo { margin-top: 1rem; diff --git a/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.tsx b/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.tsx index a3c4264a1c..9fda3b2252 100644 --- a/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.tsx +++ b/services/app-web/src/components/SubmissionSummarySection/UploadedDocumentsTable/UploadedDocumentsTable.tsx @@ -136,10 +136,8 @@ export const UploadedDocumentsTable = ({ -
-
- {tableCaptionJSX} -
+
+ {tableCaptionJSX} {!multipleDocumentsAllowed && documents.length > 1 && !isSubmitted && ( From d38ea88fe5eb29291a4ff93475edad1b446ad70c Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Fri, 3 Nov 2023 15:13:27 -0400 Subject: [PATCH 02/10] fix issue with JAWS not calling out active tab --- services/app-web/src/components/Tabs/Tabs.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/services/app-web/src/components/Tabs/Tabs.tsx b/services/app-web/src/components/Tabs/Tabs.tsx index 1a409e9a3f..0fdfda6246 100644 --- a/services/app-web/src/components/Tabs/Tabs.tsx +++ b/services/app-web/src/components/Tabs/Tabs.tsx @@ -39,12 +39,17 @@ export const Tabs = ({ role="tab" aria-selected={activeTab === tab.name} > - + + + + {tab.name} + - + ))} - + {React.Children.map(children, (child) => { // eslint-disable-next-line @typescript-eslint/ban-ts-comment From a82c3d48e000037422a49d2d6c96dd8f36d80e16 Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Mon, 6 Nov 2023 15:43:33 -0500 Subject: [PATCH 05/10] cypress re-run From b47f858397b3c808c9e9b42ab79b714a0dc489da Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Mon, 6 Nov 2023 19:07:39 -0500 Subject: [PATCH 06/10] cypress re-run From aea7f54c542eb70257f2ecd3532935969546056d Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Tue, 7 Nov 2023 09:55:51 -0500 Subject: [PATCH 07/10] cypress re-run From 954ad7c79224398061fe43f393518967eed74661 Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Tue, 7 Nov 2023 11:13:26 -0500 Subject: [PATCH 08/10] rerun all jobs From e508a9208e568f3ffafe12e4cdbc4e325227bee9 Mon Sep 17 00:00:00 2001 From: pearl-truss Date: Wed, 8 Nov 2023 17:22:37 -0500 Subject: [PATCH 09/10] styling fix for UI regression --- .../SubmissionSummary/SubmissionSummary.module.scss | 11 +++++++---- .../src/pages/SubmissionSummary/SubmissionSummary.tsx | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.module.scss b/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.module.scss index 023f272cea..5775f46230 100644 --- a/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.module.scss +++ b/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.module.scss @@ -21,13 +21,16 @@ margin-top: 17.5px; span { font-weight: bold; - a { - display: inline; + margin-top: 0; + + &.mccrsID a { + display: inline-block; margin-left: 5px; + margin-top: 0px; + } - } - .editLink { + a.editLink { margin-top: 0; } } diff --git a/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx b/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx index 1074925c84..2c2d53cc8e 100644 --- a/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx +++ b/services/app-web/src/pages/SubmissionSummary/SubmissionSummary.tsx @@ -165,7 +165,7 @@ export const SubmissionSummary = (): React.ReactElement => { isCMSUser ? (
{pkg.mccrsID && ( - + MC-CRS record number: Date: Thu, 9 Nov 2023 11:32:06 -0500 Subject: [PATCH 10/10] ui fix for contact summary section --- .../ContactsSummarySection.tsx | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/services/app-web/src/components/SubmissionSummarySection/ContactsSummarySection/ContactsSummarySection.tsx b/services/app-web/src/components/SubmissionSummarySection/ContactsSummarySection/ContactsSummarySection.tsx index be070bb15f..5822ed58a1 100644 --- a/services/app-web/src/components/SubmissionSummarySection/ContactsSummarySection/ContactsSummarySection.tsx +++ b/services/app-web/src/components/SubmissionSummarySection/ContactsSummarySection/ContactsSummarySection.tsx @@ -43,23 +43,21 @@ export const ContactsSummarySection = ({ editNavigateTo={editNavigateTo} /> - +
{submission.stateContacts.length > 0 ? ( submission.stateContacts.map( (stateContact, index) => ( - - - } - /> - + + } + /> ) ) ) : (