-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model exposure receptor and exposure stressor as relations #64
Comments
We need to remain in line with ExO. The whole receptor/stressor thing is inherited from them. |
I',m not following. These are object properties aren't they? https://github.com/EnvironmentOntology/environmental-exposure-ontology/tree/master/src/patterns/dosdp-patterns |
Here is a good example: exposure_to_chemical_medium_route.yaml You can see:
So yes, these are modelled as object properties. @wdduncan can you give us an example where you think our use of relationships does not work? |
The axioms for exposure event include:
Based on the definition of exposure stressor:
This may be an occurrent or continuant, which will not comply with OBO core. |
This is true, I agree. These axioms live in EXO though, not ECTO. This needs to be changed there! I think we should make a ticket on EXO to use the correct relations here.. |
In your email @wdduncan you say:
I am a bit confused, because we actually do not model receptors at all, anywhere (and when I say anywhere I mean in our, not the imported_ logical axioms). None of our definitions contain receptors (afaik, @diatomsRcool)! Maybe the best would be if you would review the file called "ecto-base.owl".. It contains all the axioms we can actually do something about! |
If you don't use receptors then perhaps you shouldn't import them. I am merely pointing out that the classes Another option is to go down the ontological rabbit hole and model all the dispositions, roles, and processes that define being a stressor/receptor. IMHO, this doesn't seem worthwhile for this project. You can also just use the ExO classes and axioms and accept that ECTO will not be OBO core compliant. Such decisions are above my pay grade :) (or at least I think they are.) |
From discussion:
We may wait on this for more OBO Core development. Let's not worry about this for the moment. |
This issue hasn't been discussed in while. Since we discussed taking over ExO and/or using COB as the top-level ontology, perhaps we should revisit this. |
Update from meeting:
|
Requested Once these tickets are address (hopefully, it won't take too long), we can focus on making |
The intent of exposure receptor/stressor seem better modeled as object properties. You have an entity that causes stress to an entity. This seems like a specialization of
interacts_with
(relation). The inverse of the stressor relation would then be a receptor relation. I think this will make things easier in the long run.The text was updated successfully, but these errors were encountered: