Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snippets for all Layer classes #34

Open
38 tasks
hhkaos opened this issue Sep 26, 2023 · 1 comment
Open
38 tasks

Add snippets for all Layer classes #34

hhkaos opened this issue Sep 26, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@hhkaos
Copy link
Member

hhkaos commented Sep 26, 2023

Today the extension contain just a one snippets

Snippet Description
addLayerFromPortalItem Add a new layer to the map from an ArcGIS Online or Enterprise portal item. Contains a placeholder for the portal item id.

But there are a lot of (Layer) types.

It would be nice to have snippets for the following classes: (38 in total)

Most of these layers have the possibility to be initialized in different ways (e.g. using source or a similar property), with a url, and/or using a portalItem. Like FeatureLayer (using: source, url, portalItem), RouteLayer (using: stops, url and portalItem, StreamLayer (webSocketUrl or url), etc.

I think the portalItem is the easiest to remember, and having addLayerFromPortalItem I don't see that very relevant. I also think using the URL is probably one of the most commons ways, but also the easiest to remember. I would say having the custom-source/client-side (for been the most complex to remember) or both (including url) if you think that should be default, would be my preference for these snippets.

Does it make sense @kellyhutchins ? // cc: @RalucaNicola

@hhkaos hhkaos added the type/discussion Topic under discussion label Sep 26, 2023
@kellyhutchins
Copy link
Member

Sounds great.

@hhkaos hhkaos added help wanted Extra attention is needed and removed type/discussion Topic under discussion labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants