Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate with racket-langserver #10

Merged
merged 9 commits into from
Apr 29, 2020
Merged

Conversation

JJPro
Copy link
Contributor

@JJPro JJPro commented Apr 7, 2020

Resolves #7
Add Racket Language Client support.

Integrates with racket-langserver, which is required to be installed via:

raco pkg install racket-langserver

This requires this PR to work perfectly.
Until that PR got merged, we could have my local modified copy included in our project like now.
🎉🎉🎉

One place could be improved:

auto check and install racket-langserver if not installed.
Maybe you can help with this.


output3

@Eugleo
Copy link
Owner

Eugleo commented Apr 8, 2020

Thanks for the PR! I'll review it (hopefully) till the end of the week and let you know if I have any questions.

@Eugleo
Copy link
Owner

Eugleo commented Apr 27, 2020

@JJPro I'm having problems with launching the extension. I think it's due to me not being able to download the submodules, as you didn't provide the .gitmodules file. Could you please paste its contents here?

@Eugleo
Copy link
Owner

Eugleo commented Apr 27, 2020

@JJPro I pushed some commits, mostly fixing other issues, could you please merge them into your PR? I also added some simple CI to save me some headaches with formatting and code style.

Be sure to also read my previous comment about the submodules — you should probably commit the .gitmodules file when you're at it. Thanks!

@JJPro
Copy link
Contributor Author

JJPro commented Apr 29, 2020

@Eugleo Yep, a rebase was done and racket-langserver was added as a submodule.
A problem I discovered is that the fans could go crazy sometimes with the language server integrated. I'm not sure if that's due to implementation of racket-langserver or my code piece.

Please review. Thank you!

@Eugleo
Copy link
Owner

Eugleo commented Apr 29, 2020

Seems to be working all right, thank you for the contribution!

There's one last problem that I didn't spot before: I fear the submodules won't work for users downloading the extension from the marketplace. I'll test it out and if it indeed doesn't work, I'll ditch the submodules and leave installing the langserver on the user.

We could then maybe join forces with @jeapostrophe and help him with the langserver itself, properly implementing the outline feature and whatnot. What do you say?

@Eugleo Eugleo merged commit f996cbf into Eugleo:master Apr 29, 2020
@aymanosman
Copy link

When do you plan on publishing this change? Looks very interesting.

@Eugleo
Copy link
Owner

Eugleo commented Apr 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Racket LSP
3 participants