-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate with racket-langserver #10
Conversation
Thanks for the PR! I'll review it (hopefully) till the end of the week and let you know if I have any questions. |
861dfc2
to
cc8dbce
Compare
@JJPro I'm having problems with launching the extension. I think it's due to me not being able to download the submodules, as you didn't provide the |
@JJPro I pushed some commits, mostly fixing other issues, could you please merge them into your PR? I also added some simple CI to save me some headaches with formatting and code style. Be sure to also read my previous comment about the submodules — you should probably commit the |
5909ba1
to
7ce5361
Compare
d660e80
to
f375923
Compare
f375923
to
4f75f26
Compare
@Eugleo Yep, a rebase was done and Please review. Thank you! |
Seems to be working all right, thank you for the contribution! There's one last problem that I didn't spot before: I fear the submodules won't work for users downloading the extension from the marketplace. I'll test it out and if it indeed doesn't work, I'll ditch the submodules and leave installing the langserver on the user. We could then maybe join forces with @jeapostrophe and help him with the langserver itself, properly implementing the outline feature and whatnot. What do you say? |
When do you plan on publishing this change? Looks very interesting. |
Just making finishing touches, should be up on the marketplace later today.
… 30. 4. 2020 v 0:14, aymanosman ***@***.***>:
When do you plan on publishing this change? Looks very interesting.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFCF3IHGMXINOR77BN7DHH3RPCREDANCNFSM4MC4HXEA>.
|
Resolves #7
Add Racket Language Client support.
Integrates with racket-langserver, which is required to be installed via:
This requires this PR to work perfectly.
Until that PR got merged, we could have my local modified copy included in our project like now.
🎉🎉🎉
One place could be improved:
auto check and install
racket-langserver
if not installed.Maybe you can help with this.