Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable LSP #33

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Conversation

onvlt
Copy link
Contributor

@onvlt onvlt commented Jan 19, 2021

This solves #32

I've never worked with VS Code extension so hopefully it's implemented correctly. But it behaves correctly.

It simply subscribes a callback to onDidChangeConfiguration event which reads value of magic-racket.lsp.enabled configuration and starts/stops language client accordingly.

@Eugleo Eugleo merged commit d6a0815 into Eugleo:master Jan 20, 2021
@Eugleo
Copy link
Owner

Eugleo commented Jan 20, 2021

Thanks! I'll push the update later today.

@onvlt onvlt deleted the add-lsp-config branch January 20, 2021 09:39
@Eugleo
Copy link
Owner

Eugleo commented Jan 20, 2021

Done. (btw pokud jsi kolem Prahy rád někdy zajdu na pivko, až se to bude moct)

@onvlt
Copy link
Contributor Author

onvlt commented Jan 20, 2021

@Eugleo rád 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants