-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordered and unordered lists #381
Comments
Hello and thanks for opening this issue.
Currently, we don't support ordered and unordered lists. This is mostly because currently the library uses a hard-coded Markdown parser called ExpensiMark and it does not have this feature. However, in the future, library users will be able to pass custom Markdown parser and use custom styles for formatting so theoretically this should be possible. If you need this feature now, I think it should be pretty straightforward to extend this library in terms of Markdown parser as well as on the native side. If you need any guidance, I could provide you exact steps how to do that. I will keep you updated on that. |
Thanks for coming back to me, yes I think I'd like some guidance on extending this library for supporting these feature. Appreciate the help 🙌🏼 |
Sure! First you'll need to make changes in the JS parser here: https://github.com/Expensify/react-native-live-markdown/blob/main/parser/index.ts There's a function called Once that's complete, you'll need to implement the actual styling logic on the native side. For iOS, you'll need to edit this file: react-native-live-markdown/ios/RCTMarkdownUtils.mm Lines 97 to 136 in 457a90c
For Android, you'll need to make changes here: react-native-live-markdown/android/src/main/java/com/expensify/livemarkdown/MarkdownUtils.java Lines 105 to 168 in 457a90c
FYI We also offer consulting services, so if you need some more help with extending this library, we'd be more than happy to do so, just drop us a line at projects@swmansion.com. |
Thank you! I'll give it a try this weekend. |
Thank you for your work on this library!
Do you have any plans for implementing ordered and unordered lists?
The text was updated successfully, but these errors were encountered: