Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDE icons are not used #19

Open
peterhoeg opened this issue Mar 18, 2017 · 4 comments
Open

KDE icons are not used #19

peterhoeg opened this issue Mar 18, 2017 · 4 comments

Comments

@peterhoeg
Copy link

When running the qt5 version under KDE, the program uses its own application icons instead of the chosen KDE icon theme.

Tried on the latest 0.42.67 as well as 0.39.60.

@F1ash
Copy link
Owner

F1ash commented Mar 18, 2017

Application uses only own icon theme. it not designed for using another icon themes, because it contains very specific icon names. Using different icon themes will be broke the common style of icon set. Moreover, the application is cross-platform, so it will be difficult to achieve a single style. At the moment, using own set of icons is a working solution.

@peterhoeg
Copy link
Author

Hi @F1ash, thanks for all your work on qt-virt-manager.

Would you consider adding support for using the icons from the theme? You could even expose a user toggle that decided if the theme should be preferred.

Apart from your connection icon (the one that looks like a swan head, which I admittedly don't get), all the other icons are provided by most of the icon themes on Linux. So the change would come down to:

a) rename the existing icons to follow the freedesktop specification, and
b) use QIcon::fromTheme() to load the icons, which will automatically fall back to your application provided icons in case they don't exist.

@F1ash
Copy link
Owner

F1ash commented Mar 21, 2017

I know all it... But OSX and Win not uses freedesktop standards.
It's easier if you wrote a list of icons that need to be replaced with more understandable ones (new names, for example, from oxigen icons of the theme or same).

@peterhoeg
Copy link
Author

Just FYI, I haven't forgotten about this but I simply haven't had the time yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants