Conditionally define table.empty and table.getsize in Lua
#6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@4z0t if I am not mistaken then you also did a deepcopy implementation in C/C++. Is that functionally equivalent to the Lua version? |
|
No, there are differences. My implementation doesn't care about metatables |
|
Plus It requires a lot of changes for this PR. |
That sounds problematic yes, with the number of brain/unit references all over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Removes the Lua definitions of
table.emptyandtable.getsize. These are now defined in the engine for better performance.Requires:
Checklist