Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the script-defined playable area when it is tiny #6547

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Nov 19, 2024

Description of the proposed changes

Reported by @maudlin27 on the AI Discord, see also:

Generated and unexplored maps temporarily set the playable area to 4. This confuses the navigational mesh. When the playable area is too small we instead opt to ignore it. This solution is not ideal.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas Garanas marked this pull request as ready for review November 19, 2024 20:17
@Garanas Garanas added type: bug area: AI related to AI functions area: nav-mesh related to navigational mesh labels Nov 19, 2024
Copy link
Contributor

@maudlin27 maudlin27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a basic test on an unexplored mapgen and on a normal (explored) map and it seemed to work as expected, while the condition makes sense to me

@Garanas Garanas merged commit ffcb0a5 into develop Nov 20, 2024
3 checks passed
@Garanas Garanas deleted the Fix/navigational-mesh-in-unexplored-maps branch November 20, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI related to AI functions area: nav-mesh related to navigational mesh type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants