Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all PrepTargetState logic into the beginning of tryState #64

Open
ACat701 opened this issue Sep 20, 2024 · 3 comments
Open

Combine all PrepTargetState logic into the beginning of tryState #64

ACat701 opened this issue Sep 20, 2024 · 3 comments
Labels
🛠️ Optimizations Medium Priority - Issues addressed after functionality is complete
Milestone

Comments

@ACat701
Copy link
Collaborator

ACat701 commented Sep 20, 2024

It's really annoying to add more target states right now! All of the logic for them is repetitive and it makes it hard to create new target states. Implement the logic for the following:

public Command tryState(RobotState desiredState, StateMachine subStateMachine, Elevator subElevator, Intake subIntake,
      Transfer subTransfer, Shooter subShooter) {

    // TODO: Write this functionality in a later pr
    if (isGivenStateTargetState(desiredState)) {
      // functionality is always the same for a target state
      // if its amp then do something else
    }

@ACat701 ACat701 added the 🛠️ Optimizations Medium Priority - Issues addressed after functionality is complete label Sep 20, 2024
@TaylerUva TaylerUva added ‼️ Minimum Viable Bot URGENT - REQUIRED for minimal viable robot. Issue should be addressed immediately 🛠️ Optimizations Medium Priority - Issues addressed after functionality is complete and removed 🛠️ Optimizations Medium Priority - Issues addressed after functionality is complete ‼️ Minimum Viable Bot URGENT - REQUIRED for minimal viable robot. Issue should be addressed immediately labels Sep 25, 2024
@TaylerUva
Copy link
Member

@ACat701 @Alenguye582 is this complete per the latest PR?

@Alenguye582
Copy link
Contributor

@ACat701 @Alenguye582 is this complete per the latest PR?

I don't think it is, @ACat701 can you confirm?

@ACat701
Copy link
Collaborator Author

ACat701 commented Sep 29, 2024

Its not complete. The idea here is to combine all of the cases that are target states in the giant switch case into one if statement, which hasn't happened

@TaylerUva TaylerUva added this to the Beach Blitz milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Optimizations Medium Priority - Issues addressed after functionality is complete
Projects
None yet
Development

No branches or pull requests

3 participants