Remove slice_pair in favor of standard F* pairs
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Oct 29, 2024
|
LGTM! Karamel was the only reason we had them in the first place, if Jonathan is fixing that then I'm glad we can switch to normal pairs! |
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Oct 30, 2024
This reverts commit 3593766.
|
I can confirm C extraction works well. Thanks Gabriel! |
|
If bump again into the issue you apparently had before with native pairs, please send a repro. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ongoing extension of Karamel by @msprotz and @R1kM to support extraction to Rust stumbles on the
slice_pairtype, which foils mutability analysis: the same type cannot be used to represent both mutable and immutable slice pairs.Instead, Jonathan proposes to retire this type in favor of using standard F* pairs, which Karamel would then extract to standard Rust pairs with proper mutability per use.