Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons not displaying properly #14

Open
Kirky-J opened this issue Nov 25, 2016 · 3 comments
Open

Buttons not displaying properly #14

Kirky-J opened this issue Nov 25, 2016 · 3 comments

Comments

@Kirky-J
Copy link

Kirky-J commented Nov 25, 2016

Just installed the theme in to my Redmine 3.3 build. Mostly works perfectly but some of the links on some pages aren't being turned in to 'buttons' and still show the old small icon with overlapping text. Examples below.

Am I missing something obvious?

example2
example1

@FabriceSalvaire
Copy link
Owner

FabriceSalvaire commented Nov 25, 2016

I don't have time to fix the administration pages at the moment. But I would be happy to receive patches for this.

In practice, we have to replace the png by a fontawesome (or another font) icon in https://github.com/FabriceSalvaire/redmine-improved-theme/blob/master/private/sass/redmine/_icons.scss and sometimes in another file.

cf. #8

@Kirky-J
Copy link
Author

Kirky-J commented Nov 25, 2016

I'm a total novice when it comes to this sort of thing. However, it appears that altering the settings in _icons.scss makes no real difference and instead it seems that the application.css file needs to be altered instead.

I added a new entry for a.icon.icon-summary which is the icon associated with the Permissions report in the settings page. This seemed to create me a button but I still had no icon associated with it. I then added a further entry in the application.css file

a.icon-summary:before {
display: inline-block;
font: normal normal normal 14px/1 FontAwesome;
font-size: inherit;
text-rendering: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
padding-right: 0.66667ex;
content: ""; }

with the content: line pointing to the fa-bolt Font Awesome identifier.

Adding both of these entries seemed to have the desired effect. I did add an entry in _icons.scss for icon-summary and removed the old point to the .png image file. I also added an entry into the _buttons.scss as well but wasn't sure if this was needed.

Anyhow, I'm going to do the same for some of the other icons and then I'll figure out how to create a patch - I'm not a developer by trade but have some rusty coding skills from University days!

Thanks for the pointers.

@FabriceSalvaire
Copy link
Owner

You need a development stack to work with (SASS) scss files, application.css is generated from the scss files. It is very powerful but their is a counterpart : it isn't easy to install for lambda users. You have to install nodejs and so on.

Anyway, you can experiment with the generated css file (application.css). The knowledge of an alternative for a png is already a step further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants