Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdbMinAvailableGreaterThanHPAMinReplicas validation is actually a greater or equal then comparison #1071

Closed
2 tasks done
YuMuuu opened this issue Oct 3, 2024 · 0 comments · May be fixed by #1073
Closed
2 tasks done
Labels
bug Something isn't working stale Marked as stale by stalebot triage This bug needs triage

Comments

@YuMuuu
Copy link

YuMuuu commented Oct 3, 2024

What happened?

pdbMinAvailableGreaterThanHPAMinReplicas validation is actually a greater or equal then comparison

What did you expect to happen?

I thought successful validation bad. but it actually failed
minAvailable =5
minReplicas =5

This validation name is misleading.
I think it would be better to change the name pdbMinAvailableGreaterThanHPAMinReplicas to pdbMinAvailableGreaterThanOrEqualToHPAMinReplicas

How can we reproduce this?

https://github.com/FairwindsOps/polaris/blob/master/test/checks/pdbMinAvailableGreaterThanHPAMinReplicas/failure.equals.yaml

Version

>= 9.2.1

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

(just feelings)
It was difficult to investigate because the detailed reason for the error was unknown unless debug log was enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
2 participants