Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces without applied checks should be hidden #853

Open
rassie opened this issue Sep 27, 2022 · 2 comments
Open

Namespaces without applied checks should be hidden #853

rassie opened this issue Sep 27, 2022 · 2 comments
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability

Comments

@rassie
Copy link

rassie commented Sep 27, 2022

Is your feature request related to a problem? Please describe.
In a an OpenShift cluster, I've added an exemption on all openshift-* namespaces.

    exemptions:
    - controllerNames:
      - ""
      namespace: openshift
    - controllerNames:
      - ""
      namespace: openshift-apiserver
    - controllerNames:
      - ""
      namespace: openshift-apiserver-operator
    - controllerNames:
      - ""
      namespace: openshift-authentication
    - controllerNames:
      - ""
      namespace: openshift-authentication-operator
    - controllerNames:
      - ""
      namespace: openshift-cloud-controller-manager
    - controllerNames:
      - ""
      namespace: openshift-cloud-controller-manager-operator
[...]

However, these namespaces are still shown in the dashboard with "No checks applied" comment hidden in the collapsed section.

image

This is unintuitive and noisy.

Describe the solution you'd like
Hide every namespace without applied checks in it.

@rassie rassie added enhancement Adding additional functionality or improvements triage This bug needs triage labels Sep 27, 2022
@mggude mggude added priority: could Future work depending on bandwidth and availability and removed triage This bug needs triage labels Nov 17, 2022
@mggude
Copy link
Contributor

mggude commented Nov 17, 2022

Hello! This sounds like great idea. Is this something you would be willing to work on?

@sudermanjr sudermanjr added the pinned Prevents stalebot from removing label Nov 17, 2022
@needleshaped
Copy link

needleshaped commented Feb 16, 2023

Generalizing request: this is not only about namespaces, but all object types: ConfigMap, ServiceAccount, ClusterRole, ClusterRoleBinding, etc, etc, even if those are not under exemption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing priority: could Future work depending on bandwidth and availability
Projects
None yet
Development

No branches or pull requests

4 participants