Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Feature Request - Thread-safe hologram visibility logic #146

Open
IllusionTheDev opened this issue Sep 30, 2024 · 0 comments
Open

API Feature Request - Thread-safe hologram visibility logic #146

IllusionTheDev opened this issue Sep 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@IllusionTheDev
Copy link

By default, attempting to force-hide a hologram in the main thread results in an exception being thrown, as the HologramHideEvent needs to be called async.

Proposed solution: Allow the event to be called both sync and async.
Alternative solution: Rework the API to return a CompletableFuture and handle the logic async (shouldn't be needed, it's just sending a packet).

@OliverSchlueter OliverSchlueter added the enhancement New feature or request label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants