Replies: 1 comment
-
That's a very good point, will do moving forwards. Thank you. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey @FedeClaudi,
Regarding the history of the repo, I think squashing commits using the github interface when merging a PR is something you'd want to consider, especially since your package is starting to be used by other devs.
This keeps the repo history clean, see as an example what we do with
Unicodeplots.jl
: as single commit such as JuliaPlots/UnicodePlots.jl@7ad058b squashing the 50+ commits of the PR JuliaPlots/UnicodePlots.jl#217.This avoids un-necessary merge commits and polluting the history with development details (reverts, ...), and still allow details to be accessed when inspecting the PR link added to the final commit message.
Beta Was this translation helpful? Give feedback.
All reactions