Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SID and SHD do not get the same results as the author of SID #137

Open
Flopp88 opened this issue Jun 27, 2022 · 3 comments
Open

SID and SHD do not get the same results as the author of SID #137

Flopp88 opened this issue Jun 27, 2022 · 3 comments
Labels

Comments

@Flopp88
Copy link

Flopp88 commented Jun 27, 2022

Hello,

While experimenting on the SID metric, I tried to reproduce the example from the paper presenting the SID: https://www.researchgate.net/publication/237053920_Structural_Intervention_Distance_SID_for_Evaluating_Causal_Graphs (page 4)

The autor states that when comparing H1 and H2 to the ground truth graph G, we have SHD(G,H1)=SHD(G,H2)=1 , SID(G,H1)=0 and SID(G,H2)=8
However, when runing the code (SID.zip) on the equivalent adjacency matrices, it outputs:
SHD(G,H1)=1
SHD(G,H2)=2
SID(G,H1)=1
SID(G,H2)=8

When trying with SID_CPDAG and SHD_CPDAG, it outputs:
SHD_CPDAG,(G,H1)=1
SHD_CPDAG,(G,H2)=0
SID_CPDAG(G,H1)=[1, 1]
SID_CPDAG(G,H2)=[8, 8]

What could be the issue ?
Thank you for your help

@diviyank
Copy link
Collaborator

Hello,
Could you try directly in R using the author's package?
https://cran.r-project.org/src/contrib/Archive/SID/
Best regards,
Diviyan

@Flopp88
Copy link
Author

Flopp88 commented Jul 12, 2022

When running the author's package on R, i obtain the same results as in the paper:
image
image

@diviyank
Copy link
Collaborator

Thanks for the feedback! This is really troubling... There might be data transfer issues between the languages! I'll look into this, thanks!

@diviyank diviyank added the bug label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants