Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleVerb doesn't seem to initialize correctly #43

Open
BOBONA opened this issue Jan 2, 2024 · 0 comments
Open

SimpleVerb doesn't seem to initialize correctly #43

BOBONA opened this issue Jan 2, 2024 · 0 comments

Comments

@BOBONA
Copy link

BOBONA commented Jan 2, 2024

I don't know so much about reverb algorithms, but I think there's a glitch in the initialization of this class. The comb1Length member variable (and the other combLengths) aren't initialized until setParameters is called. This would be fine, except the setParameters method checks if the input differs from the current fader values which actually are initialized in the constructor. Meaning, if someone called setParameters once with roomSizeIn=0.5 then the combLengths would continue to be uninitialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant