-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNG SDK Support in LibRaw Fork #22
Comments
I did some research on this and have some updates. Building With DNG 1.4The LibRaw project is compatible with the DNG SDK v1.4 which is compatible with older versions of Visual Studio. I was able to get the SDK compiling for both x86 and x64 windows binaries using Visual Studio 2013 inside of a virtual machine. I needed to make the following changes to the build script In the fileonq fork of LibRaw I updated both
DNG SDK Location The DNG SDK comes pre-loaded with the necessary code to compile as well as the necessary lib files for XMPCore. To ensure everything was in the right place I created a
You will need to ensure you are using the correct x64 vs x86 lib files for everything to compile correctly. Code ChangesIf we want to leverage this correctly, we will need to add new C-API methods for creating and deleting the
As far as I can tell there is no API for creating the Build AgentTo properly add DNG SDK to the build agent we will need to configure Visual Studio 2013 which will help us generate the correct binaries of the DNG library. Right now I was able to set this up in a Virtual Machine to isolate moving parts. If we are to add proper support for this, the GitHub Actions Build Agent will need to install VS2013. I am not 100% sure how to automate this and it is an unknown if we proceed. Test DataAt the moment our test data does not have any dng files that require the full Adobe DNG SDK. It is difficult to evaluate if this is working how it is supposed to. I am planning to get more data points so we can evaluate it, but if anyone has dngs that don't work with the library that would be helpful to add to out test suite. |
Description
Some DNG files are not opening correctly in our compilation instructions for LibRaw. This is because we need to add full support for compiling with DNG SDK 1.4 and XMPCore.
Solution
Update LibRaw fork and builds to properly compile LibRaw using DNG SDK flags. This is not a simple compiler flag as these tools need to be installed on the build box and/or local development machine requiring different versions of Visual Studio. For example to compile XMPCore with their latest July 2021 release, you still need VS2017.
cc: @manoj252 @mitchelsellers
The text was updated successfully, but these errors were encountered: