Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion files are not installed to Homebrew Cellar #19

Open
Myridium opened this issue Aug 7, 2022 · 1 comment
Open

Completion files are not installed to Homebrew Cellar #19

Myridium opened this issue Aug 7, 2022 · 1 comment

Comments

@Myridium
Copy link

Myridium commented Aug 7, 2022

$ make install PREFIX="$(brew --cellar)/passage/dev"
install: mkdir /opt/homebrew/Cellar/passage
install: mkdir /opt/homebrew/Cellar/passage/dev
install: mkdir /opt/homebrew/Cellar/passage/dev/lib
install: mkdir /opt/homebrew/Cellar/passage/dev/lib/passage
install: src/platform/darwin.sh -> /opt/homebrew/Cellar/passage/dev/lib/passage/platform.sh
install: mkdir /opt/homebrew/Cellar/passage/dev/lib/passage/extensions
install: mkdir /opt/homebrew/Cellar/passage/dev/bin
install: src/.passage -> /opt/homebrew/Cellar/passage/dev/bin/passage
@FiloSottile
Copy link
Owner

Hmm, that's because autodetection is looking inside the prefix, which doesn't work with Homebrew's symlinking approach.

passage/Makefile

Lines 8 to 10 in a42b9c1

BASHCOMPDIR ?= $(PREFIX)/share/bash-completion/completions
ZSHCOMPDIR ?= $(PREFIX)/share/zsh/site-functions
FISHCOMPDIR ?= $(PREFIX)/share/fish/vendor_completions.d/

The best solution might be to just autodetect installation to the Homebrew Cellar.

@FiloSottile FiloSottile changed the title Completion files are not installed by Makefile. Completion files are not installed to Homebrew Cellar Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants