test: create a test app for OpenTelemetry work #1202
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a test app for the work in #1191. It illustrates the issues I'm seeing and makes it easier for others to try things out. You can test this wth the following: In one terminal window, run: ``` node ./packages/opentelemetry/test/end-to-end/scripts/run.js ``` This starts a test app on port 4001 which has OpenTelemetry metrics enabled. I've overridden the OpenTelemetry package internals to log metrics to `stdout` instead of sending to a collector. Once you've done this, run the following: ``` curl http://localhost:4001 ``` You should see some metrics get logged. Note two things about them: 1. There is never a metric logged for the node-fetch request 2. No custom attributes come through on the logged metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a test app for the work in #1191.
It illustrates the issues I'm seeing and makes it easier for others to try things out. You can test this wth the following:
In one terminal window, run:
This starts a test app on port 4001 which has OpenTelemetry metrics enabled. I've overridden the OpenTelemetry package internals to log metrics to
stdoutinstead of sending to a collector.Once you've done this, run the following:
You should see some metrics get logged. Note two things about them:
There is never a metric logged for the node-fetch request
No custom attributes come through on the logged metrics
CPREL-1169