Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview area with dock doesn't work properly #168

Closed
ElectricRCAircraftGuy opened this issue Sep 5, 2023 · 4 comments
Closed

preview area with dock doesn't work properly #168

ElectricRCAircraftGuy opened this issue Sep 5, 2023 · 4 comments
Assignees

Comments

@ElectricRCAircraftGuy
Copy link

ElectricRCAircraftGuy commented Sep 5, 2023

Title I recommend for this issue:

Usability Problems in WinTile - drag area is too small, and works only to the right of the launcher bar in the left-hand pane of the screen

I'm temporarily switching back to WinTile Reloaded until someone can fix this, because it has better usability for my needs. I really appreciate your work in WinTile though, and hope to see these bugs fixed in WinTile so WinTile Reloaded can die as a fork.

I'll update my answer here accordingly.

2 bugs I'm hoping to see fixed in WinTile:

  1. WinTile no longer snaps windows if you drag to the far left-hand side. You have to very carefully drag it just to the right of the launcher bar instead of all the way to the left of the screen. WinTile Reloaded works fine dragging all the way to the left of the screen. I think this is a recent regression in WinTile. See screenshots below.
  2. WinTile has a too-narrow band you must drag it to for 1/2-screen snap instead of 1/4-screen corner snap. WinTile Reloaded is more usable in this regard too. See screenshots below. I think this is a long-standing problem in WinTile, not a recent regression.

Screenshots:

My WinTile settings:

image

My WinTile Reloaded settings:

image

Note

It would also be nice if you'd put the commit hash of the version being run into the name or settings when you build it, so we can easily see exactly which version and commit hash we are running. Here's my answer on how to easily get the commit hash in Bash. See git_get_short_hash. See the bottom of that answer for how to do it in Python too.

Screenshots showing the snapping behaviors:

This yellow box is the area I must drag a window in WinTile for it to snap to the left 1/2 of the screen. Notice how narrow (left and right) and short (top to bottom) it is, and how I must be to the right of the launcher bar for it to even work:

Selection_173_wintile

Contrast this to WinTile Reloaded, where I can drag it all the way against the left-side of my monitor, and in which it has a much larger area I can drag it to to get the desired behavior, as indicated by this yellow box. WinTile Reloaded is therefore far easier and faster to resize and snap a window to where I want: either a corner or a side.

Selection_173_wintile_reloaded

@ElectricRCAircraftGuy ElectricRCAircraftGuy changed the title Usability Problems in WinTile (WinTile Reloaded is still better) Usability Problems in WinTile (WinTile Reloaded is still better) - drag area is too small, and only to the right of the launcher bar in the left-hand pane of the screen Sep 5, 2023
@ElectricRCAircraftGuy ElectricRCAircraftGuy changed the title Usability Problems in WinTile (WinTile Reloaded is still better) - drag area is too small, and only to the right of the launcher bar in the left-hand pane of the screen Usability Problems in WinTile (WinTile Reloaded is still better) - drag area is too small, and works only to the right of the launcher bar in the left-hand pane of the screen Sep 5, 2023
@GrylledCheez GrylledCheez closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
@GrylledCheez GrylledCheez changed the title Usability Problems in WinTile (WinTile Reloaded is still better) - drag area is too small, and works only to the right of the launcher bar in the left-hand pane of the screen I like Wintile Reloaded better Sep 5, 2023
@GrylledCheez
Copy link
Collaborator

If you want the center snap area to be larger change the 5 in row 799 to be 2.

Call it a favor.

@ElectricRCAircraftGuy
Copy link
Author

ElectricRCAircraftGuy commented Sep 5, 2023

Note to self: lines 795 and 799:

wintile/extension.js

Lines 794 to 800 in d33631a

var centerOfScreenH = monitor.x + Math.floor(monitor.width / 2);
var columnWidthFraction = Math.floor(colWidth / 5);
var nearCenterH = mouseX > centerOfScreenH - (columnWidthFraction / 2) && mouseX < centerOfScreenH + (columnWidthFraction / 2);
var centerOfScreenV = monitor.y + Math.floor(monitor.height / 2);
var rowHeightFraction = Math.floor(rowHeight / 5);
var nearCenterV = mouseY > centerOfScreenV - (rowHeightFraction / 2) && mouseY < centerOfScreenV + (rowHeightFraction / 2);

@GrylledCheez GrylledCheez changed the title I like Wintile Reloaded better preview area with dock doesn't work properly Sep 6, 2023
Repository owner deleted a comment from ElectricRCAircraftGuy Sep 6, 2023
@GrylledCheez
Copy link
Collaborator

@ElectricRCAircraftGuy, I'm going to clean up this comment section. I was having a rough day. But I can reproduce your issue now.

@GrylledCheez GrylledCheez reopened this Sep 6, 2023
Repository owner deleted a comment from ElectricRCAircraftGuy Sep 6, 2023
Repository owner deleted a comment from ElectricRCAircraftGuy Sep 6, 2023
Repository owner deleted a comment from ElectricRCAircraftGuy Sep 6, 2023
Repository owner deleted a comment from ElectricRCAircraftGuy Sep 6, 2023
@GrylledCheez GrylledCheez self-assigned this Sep 6, 2023
GrylledCheez added a commit that referenced this issue Sep 6, 2023
The bounds check stopped previews from being registerd if the mouse was over
a panel because the panel is "outside" the working space of the monitor.

fixes #168
@GrylledCheez
Copy link
Collaborator

GrylledCheez commented Sep 6, 2023

@ElectricRCAircraftGuy see if #171 works for you (you'll still need to change the rowHeightFraction if you want that)

ElectricRCAircraftGuy added a commit to ElectricRCAircraftGuy/eRCaGuy_hello_world that referenced this issue Sep 7, 2023
...to have explicit WinTile Reloaded installation instructions again,
   since [WinTile Reloaded still works better, unfortunately](Fmstrat/wintile#168).

    :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants