Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazaar is browsable despite Privacy Mode active by default #38

Open
rikmarais opened this issue Jun 25, 2024 · 0 comments
Open

Bazaar is browsable despite Privacy Mode active by default #38

rikmarais opened this issue Jun 25, 2024 · 0 comments

Comments

@rikmarais
Copy link
Contributor

rikmarais commented Jun 25, 2024

See Creating and Hiding Folders section of https://foundryvtt.com/article/file-picker/

This toggle is available for default Foundry Filepicker sources User and Core, but not for Bazaar and Assets Library

image

This is because Privacy Mode is always turned on on Forge for Bazaar and Assets Library sources, and relies on an API key to share a specific folder from the Forge Assets Library.

image

Despite privacy mode being turned on, however, it's possible to browse assets on the Bazaar source.
(Note the blue tint that implies that the asset is under private mode, even if it is visible. This screenshot was taken from a player that has FilePicker browse permission in Foundry permissions.)
image

Making the Bazaar source browse-able despite being under Private Mode might be necessary so that assets referenced by relative paths are able to check if their path exists on the Bazaar (such as for jb2a or large asset packs). But showing the light blue private mode indicator but not actually hiding the assets from players with FilePicker permission is inconsistent and might cause confusion.

We should clarify that the Bazaar assets need to be browsable, if there is a technical requirement. If there isn't then the Bazaar assets shouldn't browsable while under private mode.

@rikmarais rikmarais changed the title Add support for Privacy Mode Toggle for Bazaar and Assets Library sources Bazaar is browsable despite Privacy Mode active by default Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant