Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

react-router Links stop working when inside a Shuffle #18

Open
jonaswindey opened this issue Oct 30, 2015 · 2 comments
Open

react-router Links stop working when inside a Shuffle #18

jonaswindey opened this issue Oct 30, 2015 · 2 comments

Comments

@jonaswindey
Copy link

When I use the component from react-router (latest version) inside a , the links stop working after the first re-render (remix-run/react-router#2403)

Since this works without the shuffle, this is an issue with react-shuffle.

Do you see a place where some props could be possibly overwritten?

@f0rr0
Copy link

f0rr0 commented Feb 23, 2016

You probably need to add a key to the <RouteHandler/>.

@nuclearspike
Copy link

I'm guessing this is related to shuffled items losing their context, since that's how a lot of router stuff is passed. A PR was just merged today that may resolve that for you once it makes it to the npm package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants