Support RSA keys #17
Merged
Support RSA keys #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
Foxboron
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
Foxboron
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
Foxboron
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
Closed
|
Is the restriction of RSA 2048 bits a technical limitation of TPMs? |
|
@dblitt Yes, but some TPMs might support stronger keys. I'm not sure how to figure this out dynamically so currently 2048 is good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to support RSA keys.
Note we can only do
RSA2048and it seems like most ssh servers still try to offerSHA-1.