Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid license for SketcherOffset.FCMacro #167

Open
chennes opened this issue Feb 10, 2024 · 3 comments
Open

Invalid license for SketcherOffset.FCMacro #167

chennes opened this issue Feb 10, 2024 · 3 comments

Comments

@chennes
Copy link
Member

chennes commented Feb 10, 2024

This macro contains a __license__ entry, but does not specify a valid license there. The line should be removed, or a valid SPDX license identifier put in place.

__License__ = 'License identifier from https://spdx.org/licenses/, e.g. LGPL-2.0-or-later as FreeCAD, MIT, CC0-1.0'

@galou
Copy link
Collaborator

galou commented Feb 27, 2024

@edi271 can you please react to this?

Maybe we could remove the macro since offset is now implemented natively in Sketcher?

@edi271
Copy link
Contributor

edi271 commented Mar 1, 2024

The Offset tool implemented in the Sketcher is working in an other way, that means, it returns in some situations other results than the macro. If you think best, please remove the macro.

@galou
Copy link
Collaborator

galou commented Mar 1, 2024

I don't have anything against letting the macro here if it behaves differently. Moreover, it's a well-written macro that can serve as a reference for many things.

What about the license? I can make the change myself if you name one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants