Reinstate "Fix inaccurate ticks in windows port" #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinstates PR FreeRTOS#142 that was reverted in FreeRTOS#143
|
I remember the last time we tried this some of the "Full Demo" tests that we run on the Windows Simulator to confirm FreeRTOS is behaving correctly were failing due to the tests depending on the incorrect timing in the Windows Simulator. We should confirm that when all of the "Full Demo" is enabled at the same time the tests are still passing after this update. |
|
Sorry I'm a bit new at this and I don't know what full demo tests you're referring to. Are you referring to the two Win32 demo projects in base FreeRTOS repo? What do you need me to do on my end to verify the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate "Fix inaccurate ticks in windows port"
Description
Reinstates PR #142 by that was reverted in #143 by . The reason given for the reversion was "Backing this out to merge it after the next Kernel release" which was in August 2020.
Test Steps
When running the Windows port with configTICK_RATE_HZ 1000 the program runs at roughly half real time speed.
Tested on Windows 11 24H2 on a 11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz.
Checklist:
Related Issue
#143 and #143
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.