From 875bfd2d88ba4db64d7055aa5f8580f6db31dcdc Mon Sep 17 00:00:00 2001
From: Rahul Kar <118818625+kar-rahul-aws@users.noreply.github.com>
Date: Thu, 26 Sep 2024 09:21:16 +0530
Subject: [PATCH] Fix missing parameters error in ATSAM4E (#1192)

* Fix Missing parameters error in ATSAM4E
---
 .../NetworkInterface/ATSAM4E/NetworkInterface.c        | 10 ++++++----
 source/portable/NetworkInterface/ATSAM4E/gmac.c        |  5 +++--
 .../NetworkInterface/DriverSAM/NetworkInterface.c      |  2 +-
 source/portable/NetworkInterface/DriverSAM/gmac_SAM.h  |  2 +-
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/source/portable/NetworkInterface/ATSAM4E/NetworkInterface.c b/source/portable/NetworkInterface/ATSAM4E/NetworkInterface.c
index 48a7b5bab..96ee3c48f 100644
--- a/source/portable/NetworkInterface/ATSAM4E/NetworkInterface.c
+++ b/source/portable/NetworkInterface/ATSAM4E/NetworkInterface.c
@@ -88,7 +88,8 @@
 static BaseType_t xGMACWaitLS( TickType_t xMaxTime );
 
 #if ( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 )
-    void vGMACGenerateChecksum( uint8_t * apBuffer );
+    void vGMACGenerateChecksum( uint8_t * pucBuffer,
+                                size_t uxLength );
 #endif
 
 /*
@@ -405,9 +406,10 @@ static BaseType_t xGMACWaitLS( TickType_t xMaxTime )
 
 /*#if( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 ) */
 
-void vGMACGenerateChecksum( uint8_t * apBuffer )
+void vGMACGenerateChecksum( uint8_t * pucBuffer,
+                            size_t uxLength )
 {
-    ProtocolPacket_t * xProtPacket = ( ProtocolPacket_t * ) apBuffer;
+    ProtocolPacket_t * xProtPacket = ( ProtocolPacket_t * ) pucBuffer;
 
     if( xProtPacket->xTCPPacket.xEthernetHeader.usFrameType == ipIPv4_FRAME_TYPE )
     {
@@ -419,7 +421,7 @@ void vGMACGenerateChecksum( uint8_t * apBuffer )
         pxIPHeader->usHeaderChecksum = ~FreeRTOS_htons( pxIPHeader->usHeaderChecksum );
 
         /* Calculate the TCP checksum for an outgoing packet. */
-        usGenerateProtocolChecksum( ( uint8_t * ) apBuffer, pdTRUE );
+        usGenerateProtocolChecksum( ( uint8_t * ) pucBuffer, uxLength, pdTRUE );
     }
 }
 
diff --git a/source/portable/NetworkInterface/ATSAM4E/gmac.c b/source/portable/NetworkInterface/ATSAM4E/gmac.c
index 7322ec5a0..b79c16248 100644
--- a/source/portable/NetworkInterface/ATSAM4E/gmac.c
+++ b/source/portable/NetworkInterface/ATSAM4E/gmac.c
@@ -642,7 +642,8 @@ uint32_t gmac_dev_read( gmac_device_t * p_gmac_dev,
 }
 
 
-extern void vGMACGenerateChecksum( uint8_t * apBuffer );
+extern void vGMACGenerateChecksum( uint8_t * pucBuffer,
+                                   size_t uxLength );
 
 /**
  * \brief Send ulLength bytes from pcFrom. This copies the buffer to one of the
@@ -715,7 +716,7 @@ uint32_t gmac_dev_write( gmac_device_t * p_gmac_dev,
             memcpy( ( void * ) p_tx_td->addr, p_buffer, ul_size );
         }
         #endif /* ipconfigZERO_COPY_TX_DRIVER */
-        vGMACGenerateChecksum( ( uint8_t * ) p_tx_td->addr );
+        vGMACGenerateChecksum( ( uint8_t * ) p_tx_td->addr, ( size_t ) ul_size );
     }
 
     #if ( GMAC_USES_TX_CALLBACK != 0 )
diff --git a/source/portable/NetworkInterface/DriverSAM/NetworkInterface.c b/source/portable/NetworkInterface/DriverSAM/NetworkInterface.c
index 88679b7a7..8a837dd35 100644
--- a/source/portable/NetworkInterface/DriverSAM/NetworkInterface.c
+++ b/source/portable/NetworkInterface/DriverSAM/NetworkInterface.c
@@ -161,7 +161,7 @@ static BaseType_t xPHY_Write( BaseType_t xAddress,
                               uint32_t ulValue );
 
 #if ( ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM == 1 ) && ( ipconfigHAS_TX_CRC_OFFLOADING == 0 )
-    void vGMACGenerateChecksum( uint8_t * apBuffer,
+    void vGMACGenerateChecksum( uint8_t * pucBuffer,
                                 size_t uxLength );
 #endif
 
diff --git a/source/portable/NetworkInterface/DriverSAM/gmac_SAM.h b/source/portable/NetworkInterface/DriverSAM/gmac_SAM.h
index 0f6a3e9ca..abe420607 100644
--- a/source/portable/NetworkInterface/DriverSAM/gmac_SAM.h
+++ b/source/portable/NetworkInterface/DriverSAM/gmac_SAM.h
@@ -1539,7 +1539,7 @@
 
 /* The SAM4E has problems offloading checksums for transmission.
  * The SAME70 does not set the CRC for ICMP packets (ping). */
-    extern void vGMACGenerateChecksum( uint8_t * apBuffer,
+    extern void vGMACGenerateChecksum( uint8_t * pucBuffer,
                                        size_t uxLength );
 
 /*/ @cond 0 */