Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Xilinx Zynq and Ultrascale functional differences in 4.x #1172

Open
JohnnyOpcode opened this issue Jul 25, 2024 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JohnnyOpcode
Copy link

I'd like to migrate a MPSoC (Ultrascale) project to 4.x, but

https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/source/portable/NetworkInterface/xilinx_ultrascale/NetworkInterface.c

is not keeping pace with

https://github.com/FreeRTOS/FreeRTOS-Plus-TCP/blob/main/source/portable/NetworkInterface/Zynq/NetworkInterface.c

@htibosch
Copy link
Contributor

Hello, thank you for your interest in FreeRTOS+TCP.

How do you mean that the Ultrascale driver is not keeping pace with the Zynq driver?

@ActoryOu
Copy link
Member

Hi @htibosch,
I think he means that the network interface of xilinx_ultrascale does not support multiple interface, which is introduced by TCP V4.

Hello @JohnnyOpcode,
We warmly welcome and appreciate contributions from the community to our repository. Your participation and code submissions are highly valued. Feel free to create PR once ready and we'll review it.

Thank you in advance for your support and involvement!

@ActoryOu ActoryOu added enhancement New feature or request help wanted Extra attention is needed labels Jul 26, 2024
@JohnnyOpcode
Copy link
Author

Hi @htibosch, I think he means that the network interface of xilinx_ultrascale does not support multiple interface, which is introduced by TCP V4.

Hello @JohnnyOpcode, We warmly welcome and appreciate contributions from the community to our repository. Your participation and code submissions are highly valued. Feel free to create PR once ready and we'll review it.

Thank you in advance for your support and involvement!

@ActoryOu I don't have the level of subject-matter expertise to code such a PR. I have my hands full with just the FreeRTOS robotic application (on MPSoC).

@pete-pjb
Copy link
Contributor

Hi @ActoryOu , @JohnnyOpcode and @htibosch ,

I did a port for this a number of months ago, but I have been too busy to contribute it... Please find attached zip with source, if anyone has time to get it into the source tree please feel free!

zus_gem.zip

I hope that is helpful!

Kind Regards,

Pete

@htibosch
Copy link
Contributor

Ah yes, now I understand it, Pete.
I will create a PR to upgrade the Ultrascale driver.
Thanks

@htibosch
Copy link
Contributor

I looked at the proposed new driver in detail. At the first sight it looks good.
I do have an Ultrascale, but at this moment, I don't have a budget (time) to review and test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants