Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain name handling with out DNS cache enabled #390

Closed
go2sh opened this issue Dec 6, 2021 · 10 comments
Closed

Domain name handling with out DNS cache enabled #390

go2sh opened this issue Dec 6, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@go2sh
Copy link
Contributor

go2sh commented Dec 6, 2021

I downloaded the latest multi/IPv6 branch and compiled it in default configuration. The DNS code produces compilations errors:

  • pcName is disabled in ParseSet_t, even needed for dns operation here
  • prvReadNameField is disabled, even needed here
  • ucName is disabled in freertos_addrinfo, even needed for dns operations. here
@go2sh go2sh changed the title Compilation failure in DNS source file Domain name handling with out DNS cache enabled Dec 6, 2021
@go2sh
Copy link
Contributor Author

go2sh commented Dec 6, 2021

To give some more background:

  • prvReadNameField is needed to parse the question and answer sections correctly
  • ucName and pcName might be needed with you want to fill the ai_canonname with something independently of the cache

@abhidixi11
Copy link

Hello @go2sh , apologies for late reply.
Can you please point me to the code where prvReadNameField is needed but ipconfigUSE_DNS_CACHE or ipconfigDNS_USE_CALLBACKS is not set, same for ucName and pcName. Thanks.

@htibosch
Copy link
Contributor

Hi @go2sh, thanks for reporting this. One additional question / request: could you attach your copy of FreeRTOSIPConfig.h to your post please?
It should be zipped and you can just drag the file from a file explorer to the edit box.
Thanks

@go2sh
Copy link
Contributor Author

go2sh commented Dec 31, 2021

I'am back at work on monday. I'll check my code and I can also provide you my workaround.

@AniruddhaKanhere
Copy link
Member

Hello @go2sh, any updates?

@go2sh
Copy link
Contributor Author

go2sh commented Jan 14, 2022

See the pr #405 for the code I'am using to fix the issue.

@go2sh
Copy link
Contributor Author

go2sh commented Jan 14, 2022

Hi @go2sh, thanks for reporting this. One additional question / request: could you attach your copy of FreeRTOSIPConfig.h to your post please? It should be zipped and you can just drag the file from a file explorer to the edit box. Thanks

the required option in the config is just #define ipconfigUSE_DNS_CACHE 0

@go2sh
Copy link
Contributor Author

go2sh commented Jan 14, 2022

In the integration branch it seams to be fixed already.

@AniruddhaKanhere
Copy link
Member

In the integration branch it seams to be fixed already.

Yes, that branch is not for IPv6. That branch is refactoring IPv4 source code to allow us to provide 100% test coverage and to compartmentalize the codebase.

@AniruddhaKanhere AniruddhaKanhere added the enhancement New feature or request label Jul 22, 2022
@moninom1
Copy link
Member

The issue was resolved long back by decoupling DNS cache from the core DNS functionality in the IPv4 main. And now the main and IPv6 branch has merged so issue seems to be resolved in both. Please feel free to reopen the issue if you still feel something is missing. Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants