From 836c78be904b502b89756c2beb0c1ae727e6f257 Mon Sep 17 00:00:00 2001 From: keremzorer Date: Thu, 1 Aug 2024 00:14:55 +0300 Subject: [PATCH 1/4] NetworkInterface.c changed --- source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c index 4456d517e..39fec5b9b 100644 --- a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c +++ b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c @@ -87,6 +87,10 @@ #define niEMAC_HANDLER_TASK_PRIORITY configMAX_PRIORITIES - 1 #endif +#ifndef ipconfigEMAC_WATCHDOG_TIMER + #define ipconfigEMAC_WATCHDOG_TIMER() +#endif + /* Bit map of outstanding ETH interrupt events for processing. */ static volatile uint32_t ulISREvents; @@ -1187,6 +1191,7 @@ static void prvEMACHandlerTask( void * pvParameters ) prvEthernetUpdateConfig( pdFALSE ); } } + ipconfigEMAC_WATCHDOG_TIMER(); } } From b8f1f0365e2f8721ec7711e573ef62cfbb159906 Mon Sep 17 00:00:00 2001 From: keremzorer Date: Mon, 5 Aug 2024 22:05:59 +0300 Subject: [PATCH 2/4] Add ipconfigEMAC_WATCHDOG_TIMER macro to support configurable watchdog timer --- source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c index 39fec5b9b..8854653ca 100644 --- a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c +++ b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c @@ -91,7 +91,6 @@ #define ipconfigEMAC_WATCHDOG_TIMER() #endif - /* Bit map of outstanding ETH interrupt events for processing. */ static volatile uint32_t ulISREvents; From 43ed8513b961bbd6f4f5471ffaf417dbba82dc4e Mon Sep 17 00:00:00 2001 From: Gaurav Aggarwal Date: Tue, 6 Aug 2024 17:21:41 +0000 Subject: [PATCH 3/4] Code review suggestions Signed-off-by: Gaurav Aggarwal --- .../portable/NetworkInterface/STM32Hxx/NetworkInterface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c index 4e2902c59..7eebd9db4 100644 --- a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c +++ b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c @@ -87,8 +87,8 @@ #define niEMAC_HANDLER_TASK_PRIORITY configMAX_PRIORITIES - 1 #endif -#ifndef ipconfigEMAC_WATCHDOG_TIMER - #define ipconfigEMAC_WATCHDOG_TIMER() +#ifndef ipconfigEMAC_TASK_HOOK + #define ipconfigEMAC_TASK_HOOK() #endif /* Bit map of outstanding ETH interrupt events for processing. */ @@ -1196,7 +1196,7 @@ static void prvEMACHandlerTask( void * pvParameters ) prvEthernetUpdateConfig( pdFALSE ); } } - ipconfigEMAC_WATCHDOG_TIMER(); + ipconfigEMAC_TASK_HOOK(); } } From 65fef96ea3c394095858a1c017b51f89844544c0 Mon Sep 17 00:00:00 2001 From: Gaurav Aggarwal Date: Tue, 6 Aug 2024 18:03:10 +0000 Subject: [PATCH 4/4] Fix formatting Signed-off-by: Gaurav Aggarwal --- source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c index 7eebd9db4..6536b3085 100644 --- a/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c +++ b/source/portable/NetworkInterface/STM32Hxx/NetworkInterface.c @@ -1196,6 +1196,7 @@ static void prvEMACHandlerTask( void * pvParameters ) prvEthernetUpdateConfig( pdFALSE ); } } + ipconfigEMAC_TASK_HOOK(); } }