Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename run to call! #26

Open
MatheusRich opened this issue May 20, 2021 · 0 comments
Open

Rename run to call! #26

MatheusRich opened this issue May 20, 2021 · 0 comments
Labels
breaking change good first issue Good for newcomers

Comments

@MatheusRich
Copy link
Contributor

MatheusRich commented May 20, 2021 •
edited
Loading

call! is more common in Ruby an is already present as a class method for FService::Base. We should mark run as deprecated in the next version.

We'll use call (without bang) in #27, so call! (with bang) is the drop-in replacement for run.
@MatheusRich MatheusRich changed the title Rename run to call Rename run to call! May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatheusRich