Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced DOMNodeInserted with MutationObserver #90

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

degenone
Copy link
Contributor

I noticed that there was a warning in the browser console:

[Deprecation] Listener added for a synchronous 'DOMNodeInserted' DOM Mutation Event.
This event type is deprecated (https://w3c.github.io/uievents/#legacy-event-types) and work is underway to remove it from this browser.
Usage of this event listener will cause performance issues today, and represents a risk of future incompatibility.
Consider using MutationObserver instead.

Chromium has officially deprecated mutation events, and has a plan to remove support starting with version 127, which goes to stable release on July 30, 2024.

https://developer.chrome.com/blog/mutation-events-deprecation/

Deprecated: This feature is no longer recommended.

https://developer.mozilla.org/en-US/docs/Web/API/MutationEvent/

As far as I can tell there is no change in behavior on the site with this change.

@csharpfritz
Copy link
Contributor

Looks like a failed test right now... we'll need to investigate

@csharpfritz csharpfritz merged commit c64c97f into FritzAndFriends:main Aug 15, 2023
1 of 2 checks passed
@csharpfritz
Copy link
Contributor

Thank you for the update! Looks like this is working properly with the other Playwright test fixes

@degenone degenone deleted the replace_DOMNodeInserted branch August 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants