Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Interpreter::transact work with Script only #251

Open
xgreenx opened this issue Oct 28, 2022 · 2 comments
Open

Update Interpreter::transact work with Script only #251

xgreenx opened this issue Oct 28, 2022 · 2 comments
Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 28, 2022

image

Interpreter::transact accepts Create and Script transactions. But we don't execute any script on Create, and it seems redundant and not clear that transact support both transactions. Interpreter already provides the deploy method for the Create transaction, so transact now can work only with Script, and we can remove support of Create.

It is breaking change and requires the adaptation of fuel-core and fuel-rs.

@xgreenx xgreenx added the breaking A breaking api change label Oct 28, 2022
@Voxelot
Copy link
Member

Voxelot commented Oct 28, 2022

One thing to note, we'd need to come up with an alternate way to set the change outputs on create txs for any unused fees. Deploy currently only inserts the contract into state without any alterations on the transaction itself.

@xgreenx
Copy link
Collaborator Author

xgreenx commented Oct 28, 2022

Deploy return altered Create with actual outputs

image

@mitchmindtree mitchmindtree added the fuel-vm Related to the `fuel-vm` crate. label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Development

No branches or pull requests

3 participants