Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider deprecating FUEL_NETWORK_URL and LOCAL_NETWORK_URL #2644

Open
petertonysmith94 opened this issue Jun 28, 2024 · 4 comments
Open

Consider deprecating FUEL_NETWORK_URL and LOCAL_NETWORK_URL #2644

petertonysmith94 opened this issue Jun 28, 2024 · 4 comments
Labels
blocked Something is blocking development on this issue chore Issue is a chore

Comments

@petertonysmith94
Copy link
Contributor

After we migrate to launchTestNode, we should be in a position to deprecate the following constants:

This would leave us with the following:

  • DEVNET_NETWORK_URL
  • TESTNET_NETWORK_URL
  • NETWORK_URL — upcoming mainnet

Discussion Context
@petertonysmith94 petertonysmith94 added blocked Something is blocking development on this issue chore Issue is a chore p2 labels Jun 28, 2024
@petertonysmith94

This comment was marked as outdated.

Sign in to view
@arboleya
Copy link
Member

arboleya commented Jul 4, 2024

@FuelLabs/sdk-ts Thoughts on this one?

@maschad
Copy link
Member

maschad commented Jul 4, 2024

Given that #1820 has been updated to limit launchTestNode integration to strictly the fuel-gauge suite, we need to integrate launchTestNode in a few other packages before those urls can be deprecated. I've created #2698 to address that. Once that is resolved then yes I would agree both FUEL_NETWORK_URL and LOCAL_NETWORK_URL should be deprecated

@arboleya
Copy link
Member

arboleya commented Jul 5, 2024

Blocked by:

@arboleya arboleya added p1 and removed p2 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
@nedsalk nedsalk changed the title Consider depreciating FUEL_NETWORK_URL and LOCAL_NETWORK_URL Consider deprecating FUEL_NETWORK_URL and LOCAL_NETWORK_URL Jul 29, 2024
@arboleya arboleya removed the p0 label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Something is blocking development on this issue chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arboleya @maschad @petertonysmith94