Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tsup from 6.7.0 to 8.2.1 #2666

Open
petertonysmith94 opened this issue Jul 1, 2024 · 0 comments
Open

Upgrade tsup from 6.7.0 to 8.2.1 #2666

petertonysmith94 opened this issue Jul 1, 2024 · 0 comments
Labels
chore Issue is a chore

Comments

@petertonysmith94
Copy link
Contributor

Summary

The following dependabot upgrade PR was closed due to a failing CI for a single test file (json.test.ts).

This is due to using the following logic in the normalizeJson function:

switch (object[key]?.constructor.name) {

The upgrade has caused the constructor name to change, therefore breaking the logic of detection for these entities.

We need to

@petertonysmith94 petertonysmith94 added chore Issue is a chore p1 labels Jul 1, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x post-launch milestone Jul 1, 2024
@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@petertonysmith94 petertonysmith94 changed the title Upgrade tsup from 6.7.0 to 8.1.0 Upgrade tsup from 6.7.0 to 8.2.1 Jul 22, 2024
@arboleya arboleya removed the p2 label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

2 participants