Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @types/node from 16.18.34 to 20.14.10 #2667

Closed
petertonysmith94 opened this issue Jul 1, 2024 · 3 comments · Fixed by #2809
Closed

Upgrade @types/node from 16.18.34 to 20.14.10 #2667

petertonysmith94 opened this issue Jul 1, 2024 · 3 comments · Fixed by #2809
Assignees
Labels
chore Issue is a chore

Comments

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Jul 1, 2024

Summary

The following dependabot PR was closed:

On upgrade to the @types/node the following build failure was occuring:

Error: src/providers/provider.ts(399,44): error TS2339: Property 'timeout' does not exist on type '{ new (): AbortSignal; prototype: AbortSignal; }'.

This was caused by the following line of code:

const signal = timeout ? AbortSignal.timeout(timeout) : undefined;

What we need to do

@mvares
Copy link
Contributor

mvares commented Jul 6, 2024

I've been investigating this issue and it seems that the problem is related to the Node version. I found other issues that describe the same problem.

Perhaps we will need another approach if we want to maintain AbortController.timeout(). The solution that the maintainers of other projects found was to use version 20.0 or higher.

@petertonysmith94
Copy link
Contributor Author

The solution that the maintainers of other projects found was to use version 20.0 or higher.

Hey @mvares,

Would node@v20.14.9 not satisfy these conditions?

@mvares
Copy link
Contributor

mvares commented Jul 9, 2024

Well, yes. But our code supports the version 18.0.

@petertonysmith94 petertonysmith94 changed the title Upgrade @types/node from 16.18.34 to 20.14.9 Upgrade @types/node from 16.18.34 to 20.14.10 Jul 15, 2024
@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@petertonysmith94 petertonysmith94 self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants