-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving method DX for getMessageProof
#2736
Comments
petertonysmith94
added
chore
Issue is a chore
p2
and removed
triage
Issue needs to be triaged
labels
Jul 12, 2024
I think this has merit:
|
petertonysmith94
changed the title
Improving UX from
Improving method DX for Jul 12, 2024
getMessageProof
getMessageProof
Makes sense. I think it's better to stick with the current DX. Thanks for comment, @petertonysmith94! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the code doesn't allow the use of both parameters at the same time. To use
commitBlockHeight
, I need to definecommitBlockId
asundefined
, which doesn't seem to be a comprehensible approach for users.fuels-ts/packages/account/src/providers/provider.ts
Lines 1605 to 1610 in 5b53581
Therefore, I think it might be interesting if we could define this within an object:
The text was updated successfully, but these errors were encountered: