Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for bad fasta input #64

Open
pashadag opened this issue Jul 23, 2020 · 1 comment
Open

Improve error message for bad fasta input #64

pashadag opened this issue Jul 23, 2020 · 1 comment

Comments

@pashadag
Copy link
Contributor

BCALM doesn't crash nicely when the input is an incorrect fasta file. The current error message is:

>cat blin.fa
adfad
> bcalm -in blin.fa -kmer-size 3
BCALM 2, git commit e9ba83c
setting storage type to hdf5
HDF5-DIAG: Error detected in HDF5 (1.8.18) thread 0:
  #000: /home/pzm11/research/software/bcalm/gatb-core/gatb-core/thirdparty/hdf5/src/H5F.c line 604 in H5Fopen(): unable to open file
....
EXCEPTION: Unable to open bank 'blin.fa' (if it is a list of files, perhaps some of the files inside don't exist)

The error message could be improved to suggest that a possible reason for this exception is an improperly formatted fasta file.

@rchikhi
Copy link
Member

rchikhi commented Aug 13, 2020

I appreciate the suggestion. This change requires digging deep into the FASTA and list-of-FASTA parsing of GATB, so I'd rather bundle it with a future change rather than digging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants