-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated readme.md and contributers.md #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings from GDSC AEC! Thanks for making the PR, our team will review it soon. Stay tuned 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update these Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit this
with
npm i
npm start
as someone can copy paste the codes directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Here in line 19,
Update it, as it is no longer just an HTML, CSS, and JS Website.
Now It is using React with Vite and Tailwind -
In line 28,29 Add those scripts you added in Contributing.md
after git clone ...., Add this scripts:-cd GDSCAEC-WEBSITE npm i npm start
-
After the git commit msg (line 32) add Sync your local clone in our repositories section on github and Add this script
git pull origin your_branch_name
to resolve your merge conflict locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
pls add hacktoberfest accepted label in my pr |
✅ Deploy Preview for gdscaec-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Related Issue
issue #8 -> updated the images link and added setup instruction in readme.md and contributers.md
Proposed Changes
Checklist
Screenshots