Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme.md and contributers.md #10

Merged
merged 7 commits into from
Oct 22, 2023

Conversation

priyanshu9899
Copy link
Contributor

Related Issue

issue #8 -> updated the images link and added setup instruction in readme.md and contributers.md

Proposed Changes

  • updated images link in readme.md
  • added setup instruction in contributing.md

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

Screenshot 2023-10-21 at 2 45 09 PM Screenshot 2023-10-21 at 2 45 38 PM

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from GDSC AEC! Thanks for making the PR, our team will review it soon. Stay tuned 😊

Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update these Changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit this
with

npm i
npm start

as someone can copy paste the codes directly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Here in line 19,
    Update it, as it is no longer just an HTML, CSS, and JS Website.
    Now It is using React with Vite and Tailwind

  • In line 28,29 Add those scripts you added in Contributing.md
    after git clone ...., Add this scripts:-

    cd GDSCAEC-WEBSITE
    npm i
    npm start
  • After the git commit msg (line 32) add Sync your local clone in our repositories section on github and Add this script git pull origin your_branch_name to resolve your merge conflict locally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@priyanshu9899
Copy link
Contributor Author

priyanshu9899 commented Oct 21, 2023

pls add hacktoberfest accepted label in my pr

@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for gdscaec-react ready!

Name Link
🔨 Latest commit 3cb3dac
🔍 Latest deploy log https://app.netlify.com/sites/gdscaec-react/deploys/6534cca949a9ac00086ad61e
😎 Deploy Preview https://deploy-preview-10--gdscaec-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TheCodeVenturer TheCodeVenturer merged commit 9176e28 into GDGCampusAEC:main Oct 22, 2023
4 checks passed
@TheCodeVenturer TheCodeVenturer added the hacktoberfest-accepted Label for accepted PRs made during hacktoberfest label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Label for accepted PRs made during hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants