Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent resampling for precipitation correction and rate calculation #215

Open
PennyHow opened this issue Dec 4, 2023 · 0 comments
Open
Labels
enhancement New feature or request L2 Issues with L2 data

Comments

@PennyHow
Copy link
Member

PennyHow commented Dec 4, 2023

From @ladsmund:

I was trying to understanding the time interval used to compute the precipitation rate. I found the location in the source code, but it is just using diff with respect the previous sample. I guess the interval then depends on the sample rate at that specific time.
https://github.com/GEUS-Glaciology-and-Climate/pypromice/blob/8fca6c3eb596775a9a6b676599c2068add84bdde/src/pypromice/process/L1toL2.py#L370C8-L370C8
If this is correct, then I don't think we can compare precipitation rates across stations and time. What do you think?

Response from @PennyHow:

We calculate it with respect to the previous sample like you say. But I think there are better ways to calculate precipitation rate. This calculation is just based on a correction calculation from Jason. We implemented it to match what Jason was doing. But if you want to compare across stations, then maybe we can find a better solution?

@ladsmund

I think it will make sense to define the rate wrt an explicit interval such as hourly or daily.

@PennyHow

We could definitely do that... so a resample everything to hourly or daily intervals before performing the correction and rate calculation

@PennyHow PennyHow added enhancement New feature or request L2 Issues with L2 data labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request L2 Issues with L2 data
Projects
None yet
Development

No branches or pull requests

1 participant