Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether PROMICE-AWS-data-issues is found depends on where get_l3 is run: should be changed for absolute path #234

Open
BaptisteVandecrux opened this issue Apr 12, 2024 · 0 comments

Comments

@BaptisteVandecrux
Copy link
Member

BaptisteVandecrux commented Apr 12, 2024

Since github_data_issue.py look for flag and adjustment CSVs at

def flagNAN(ds_in,
flag_dir='../PROMICE-AWS-data-issues/flags'):

whether it finds it or not depends on where pypromice is run.

I noticed that when because l3_reprocess.py was running fine but l3_processor.py could not find the flag files. This is because l3_processor.py was running get_l3 in the ./pypromice/src/pypromice folder and the relative path to the flag files was broken.

To prevent this from re-happening, I suggest that get_l3 would give the absolute paths of the flags and adjustment files instead of the relative path.

I also suggest that l3_reprocess.py and l3_processor.py should only make CLI calls containing absolute paths (instead of switching from folder to folder with cd).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant