Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved detailed overview of BM/GMM bodies #1932

Merged

Conversation

tomudding
Copy link
Member

Description

Provides access to the historical BM/GMM bodies overview, which was previously implemented (see GH-1797) but never linked. On top of that, you can now directly go from the detailed overview of a body to its public page/profile.

Fixes an incorrect translations and removed some potential sources for XSS in a body's abbreviation and name.

Related issues/external references

Closes GH-1927 and closes GH-1928.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

Somehow, this was translated as "expiration date" and not "abrogation date".
I implemented the functionality for this through GEWISGH-1797, however, I never added
the necessary links to be able to access the page.
…rview

Does not work properly for abrogated bodies that share their abbreviation with
newer bodies, see GEWISGH-1925.
@tomudding tomudding merged commit da43dc2 into GEWIS:main Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant