Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against file corruption during download #73

Open
boubou19 opened this issue Sep 25, 2022 · 2 comments
Open

guard against file corruption during download #73

boubou19 opened this issue Sep 25, 2022 · 2 comments

Comments

@boubou19
Copy link
Member

Today i tried to assemble manually the 2.2.0.0 RC3 via DAXXL, without changing the locale, resulting in #47. So when i saw that, i terminated my python process, changed the local and rerun DAXXL. That caused the downloads to be killed, resulting in corrupted files.

Because DAXXL assumes that if a file is present, then it's valid, i managed to assemble """valid""" 2.2.0.0 RC3 with a weight of 355MB instead of 435MB.

This is a real issue as if we can assume the cache is corrupted if UnicodeDecodeError arise during download, we have no check against random packet corruption when files are downloaded.

@mitchej123
Copy link
Contributor

Sounds like we need file hashes or size estimates

@mitchej123
Copy link
Contributor

Another option is to start signing release jars.... Daxxl can verify those..... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants