Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TX-Loader always fetches minecraft versions #18348

Open
2 of 3 tasks
Caedis opened this issue Dec 12, 2024 · 2 comments
Open
2 of 3 tasks

TX-Loader always fetches minecraft versions #18348

Caedis opened this issue Dec 12, 2024 · 2 comments
Labels
Bug: Minor Status: Ready for Developer Issue ready for a developer to pick up and implement

Comments

@Caedis
Copy link
Member

Caedis commented Dec 12, 2024

Your GTNH Discord Username

Caedis

Your Pack Version

latest nightly

Your Server

private

Java Version

Java 21

Type of Server

Vanilla Forge

Your Expectation

Currently having some unstable internet and wanted started the pack and hung on loading the TX-Loader coremod for a bit.

The Reality

TXLoader always pulls the latest minecraft version manifests even though this is a 1.7.10 only mod.
When there is no/unstable internet, this can cause increased pack load times.

Your Proposal

Cache the 1.7.10 manifest locally after first pack load, or hard code it as a resource in the mod.
https://piston-meta.mojang.com/v1/packages/ed5d8789ed29872ea2ef1c348302b0c55e3f3468/1.7.10.json

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@Caedis Caedis added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 12, 2024
@RAFAEL-SOSA-UH RAFAEL-SOSA-UH added Status: Ready for Developer Issue ready for a developer to pick up and implement Type: Not GTNH About a non-GTNH usecase. Can still be relevant for GTNH or can be on an actively supported mod. and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 13, 2024
@Caedis
Copy link
Member Author

Caedis commented Dec 13, 2024

Think we decided to just cache all manifests instead of just 1.7.10

@chochem chochem removed the Type: Not GTNH About a non-GTNH usecase. Can still be relevant for GTNH or can be on an actively supported mod. label Dec 13, 2024
@Glease
Copy link
Contributor

Glease commented Dec 20, 2024

I think one of the features of TX-loader is to use assets from modern MC versions without shipping it with your mod. It probably fetches those on purpose, albeit a bit wasteful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Ready for Developer Issue ready for a developer to pick up and implement
Projects
None yet
Development

No branches or pull requests

4 participants